Do not keep searching for recent #16424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If userA has a lot of recent files. But only shares 1 file with userB (that has no files at all). We could keep searching until we run out of recent files for userA. Now assume the inactive userB has 20 incomming shares like that from different users. getRecent then basically keeps consuming huge amounts of resources and with each iteration the load on the DB increases (because of the offset). This makes sure we do not get more than 3 times the limit we search for or more than 5 queries. This means we might miss some recent entries but we should fix that separatly. This is just to make sure the load on the DB stays sane. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
requested review from
nickvergessen,
MorrisJobke,
blizzz and
juliushaertl
This was referenced Jul 16, 2019
Closed
|
/backport to stable16 |
|
/backport to stable15 |
|
/backport to stable14 |
|
We cannot backport this to stable15/stable14 but stable16 should be fine: #14185 |
Why not? The PR was also back ported to 14 and 15. |
I missed that 🙈 |
|
backport to stable16 in #16432 |
|
backport to stable15 in #16433 |
|
backport to stable14 in #16434 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If userA has a lot of recent files. But only shares 1 file with userB
(that has no files at all). We could keep searching until we run out of
recent files for userA.
Now assume the inactive userB has 20 incomming shares like that from
different users. getRecent then basically keeps consuming huge amounts
of resources and with each iteration the load on the DB increases
(because of the offset).
This makes sure we do not get more than 3 times the limit we search for
or more than 5 queries.
This means we might miss some recent entries but we should fix that
separatly. This is just to make sure the load on the DB stays sane.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl